Preventing multiple observers for the same notification #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same notification
|
Thanks for noticing this issue and providing a fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a video is set to repeat the attachListeners method gets called on every cycle thus adding the same observer over and over again, which all get called at the end of a cycle which is kinda pointless. This can be mitigated by first removing the observer before adding it.
I encountered this behaviour while debugging to find out why this 'AVPlayerItemDidPlayToEndTimeNotification'-observer did not get called for the second time for repeat m3u8 videos on iOS 11. The bug report can be found here.