Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS video not displaying after switching source #1395

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

cobarx
Copy link
Contributor

@cobarx cobarx commented Dec 22, 2018

Fixes #1394

When switching videos on iOS the video loads but does not display. I tracked this down to:
https://github.com/react-native-community/react-native-video/pull/1310/files#diff-42e8804735be64e84d6dd1fb103210a1R861
where applying modifiers while setting the source causes us to lose the player layer and not display the new video.

@ashnfb Please do your best to do extensive testing around switching sources & different video types before submitting PRs. We need to do everything we can to avoid regressions creeping into releases as this breaks apps for numerous developers. It ended up taking about an hour and a half to track this down which would be best spent on reviewing PRs & fixing bugs.

@n1ru4l heads up on regression

@cobarx cobarx merged commit 478c135 into master Dec 22, 2018
@cobarx cobarx deleted the bugfix/maxbitrate-apply-mods branch January 1, 2019 05:59
@Wangzihao5325
Copy link

When i switching videos on iOS if i set controls={true} everything is ok ,but if i set controls={false} audio is ok but screen will not change. version is 4.2.0. sorry for my poor english - -!

beauner69 pushed a commit to beauner69/react-native-video that referenced this pull request Oct 10, 2019
…ugfix/maxbitrate-apply-mods

Fix iOS video not displaying after switching source

(rebased from commit 478c135)
@alencrowdbotics
Copy link

alencrowdbotics commented Dec 3, 2020

When i switching videos on iOS if i set controls={true} everything is ok ,but if i set controls={false} audio is ok but screen will not change. version is 4.2.0. sorry for my poor english - -!

The reverse will happen in my case. When i switch source and controls={true} the video freezes audio plays on the background. When controls={false} video reloads.

5.0.2 and 5.1.0-alpha8

@alencrowdbotics
Copy link

alencrowdbotics commented Dec 12, 2020

For anyone else facing this issue try to add

    maxBitRate={anyvalue}

For our case either the controls on or off froze the video. Somehow it affects the bitrate maybe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change source uri dynamically
3 participants