Avoid crash on ExoPlayer when there are no tracks to choose from #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobarx
changed the title
rrosatti
added a commit
to alanpazetto/react-native-video
that referenced
this pull request
May 6, 2019
…rack available This fix was integrated on version 4.0.0. We need it in order to fix a problem on Android, where the video freezes on the first frame when using a remote url instead of an asset. link to the upstream PR: TheWidlarzGroup#1233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1190
What was happening is that the video contained no audio tracks, it would still attempt to select the audio track with index 0. We now check that there are tracks to choose from and if there aren't return the unset constant so that we turn of the renderer for that type of track.