Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce package size #1231

Merged
merged 2 commits into from
Sep 23, 2018
Merged

Reduce package size #1231

merged 2 commits into from
Sep 23, 2018

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Sep 12, 2018

No description provided.

@retyui
Copy link
Contributor Author

retyui commented Sep 12, 2018 •
edited
Loading

On PR branch

npm pack 

#npm notice package size:  74.7 kB                                 
#npm notice unpacked size: 332.0 kB

On master branch

npm pack

#npm notice package size:  344.5 kB                                
#npm notice unpacked size: 660.1 kB

@cobarx
Copy link
Contributor

cobarx commented Sep 22, 2018

Thanks for contributing this!

@cobarx cobarx closed this Sep 22, 2018
@retyui
Copy link
Contributor Author

retyui commented Sep 23, 2018

@cobarx
Why did you close this PR without a merger?

@cobarx cobarx reopened this Sep 23, 2018
@cobarx cobarx merged commit 2e3ded7 into TheWidlarzGroup:master Sep 23, 2018
@cobarx
Copy link
Contributor

cobarx commented Sep 23, 2018

Oops had meant to merge this and hit close by accident. Sorry about that.

@retyui retyui deleted the npm-package branch September 23, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retyui @cobarx