Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] Cleanup #21

Closed
2 tasks
krizzu opened this issue Feb 26, 2019 · 4 comments
Closed
2 tasks

[General] Cleanup #21

krizzu opened this issue Feb 26, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@krizzu
Copy link
Member

krizzu commented Feb 26, 2019

About

I call this cleanup task, but it's actually a to do that I believe will increase the usability of this repo.
Open for any discussion/proposals. If someone would like to help with anything, feel free to (just post in this issue).

Todo list

Auto-generated documentation

  • In progress

I believe simple HTML-from-markdown generator would do the job. We currently have two pages - API and Manual Linking - so GitHub pages should be sufficient to display them as HMTL.

Unit tests for JS interface

  • In progress

Test public interface that consumes the native module.

Done:

GitHub template issues

To help maintainers maintain and issuers issue, unified way of communication is the key. I believe a separate template for bugs, feature request, and questions would be helpful here.

Write CONTRIBUTORS guide

A helpful guide for newcomers, willing to help out with Async Storage.

Automatic sematic releases

Automatic, regular, semantic releases with patches/fixes would be useful.


More to come

The list will keep growing over time, so feel free to post your ideas/thoughts.

Thanks!

@krizzu krizzu added the enhancement New feature or request label Feb 26, 2019
@krizzu krizzu pinned this issue Feb 26, 2019
@jcurtis
Copy link

jcurtis commented Mar 27, 2019

I've noticed the "Manual Linking" guide is missing info for iOS https://github.com/react-native-community/react-native-async-storage/blob/master/docs/Linking.md

@krizzu
Copy link
Member Author

krizzu commented Mar 27, 2019

@jcurtis Hey,

Would you like to help with that?
I'd love this guide to have some screenshots from manual linking steps, I find those more useful than raw text.

thanks.

@jcurtis
Copy link

jcurtis commented Mar 27, 2019

@krizzu I ended up using the steps from the react native docs 👉 https://facebook.github.io/react-native/docs/linking-libraries-ios#manual-linking

@tido64 tido64 unpinned this issue May 4, 2019
@tido64 tido64 pinned this issue May 4, 2019
@krizzu krizzu unpinned this issue May 28, 2019
@krizzu krizzu added LEGACY and removed LEGACY labels Jun 18, 2019
@krizzu
Copy link
Member Author

krizzu commented Jul 4, 2019

Closing this in favor of v2.

@krizzu krizzu closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants