Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to override built in commands #2227

Closed
tom-sherman opened this issue Dec 21, 2023 · 1 comment · Fixed by #2229
Closed

Allow plugins to override built in commands #2227

tom-sherman opened this issue Dec 21, 2023 · 1 comment · Fixed by #2229

Comments

@tom-sherman
Copy link

Describe the Feature

Commands and healthchecks defined in the config should override built-in commands so that I can, for example, provide my own react-native start command implementations.

This would allow repack to override the start command instead of requiring an alternative webpack-start cmd.

Possible Implementations

I believe it requires flipping the order here:

commands: [...acc.commands, ...config.commands],

However I tried this and it didn't allow me to override start.

Related Issues

This would offer a first party solution to nrwl/nx#20847

@szymonrybczak
Copy link
Collaborator

Hey @tom-sherman, I think we can add support for this! Also for Re.Pack it will solve one other problem - when we're running run-ios we're also starting new window where we run start command, and in most cases it opens Metro instance which can be confusing for non-advanced users 😅 cc @jbroma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants