doctor: check for required catalyst build tweaks

[mikehardy]

Describe the Feature

Building for catalyst is very difficult - if the user has SUPPORTS_MACCATALYST as YES -

Tweaks to check:

• dead code stipping is on (Doctor could check for DEAD_CODE_STRIPPING=NO and warn users of possible build failures #1572 (comment))
• you have a development team set https://github.com/mikehardy/rnfbdemo/blob/cca01dd3f6209aed03c4ff80e590d57280f58257/make-demo.sh#L230
• you have the Podfile tweak that turns on adhoc signing for cocoapods resources ([Catalyst] Podspec Resource Bundle requires a development team CocoaPods/CocoaPods#8891 (comment))
• you have a fancy library path addition https://github.com/mikehardy/rnfbdemo/blob/cca01dd3f6209aed03c4ff80e590d57280f58257/make-demo.sh#L242-L243
• you have an entitlements file https://github.com/mikehardy/rnfbdemo/blob/cca01dd3f6209aed03c4ff80e590d57280f58257/make-demo.sh#L223-L226

Possible Implementations

Mostly pbxproj verification with exception of the postinstall Podfile thing, not sure how to check Podfile contents other than a grep?

Related Issues

facebook/flipper#3117 (comment)

[cortinico]

As a side note: should those requirements be documented somewhere?

[mikehardy]

Almost certainly? 😅 This is not really the place to discuss it but I can make a website PR that adds (or edits?) a macCatalyst section and documents it, as well as the limitations. Probably shouldn't merge that until 68 since it'll build-break for a lot of people until 0.68 is out with the fixes for things that broke from 0.65-0.67. Good thought though, right now there's exactly one mention of catalyst and it's just an announcement

Ironically for 0.65, which will not compile if people try to use flipper :-). A tangled web we weave

[cortinico]

I think that we can have a page under the iOS guides here:

[github-actions]

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.