From a00a896c671eb7ff0666df6f507e09ae2d993bec Mon Sep 17 00:00:00 2001 From: Blake Friedman Date: Thu, 11 May 2023 09:36:08 +0100 Subject: [PATCH] feat: only show --verbose flag if there are hidden logs (#1925) We currently always show details about this flag. The change will only log this message if there are debug log messages an the user is not in --verbose mode. --- packages/cli-tools/src/logger.ts | 6 ++++++ packages/cli/src/index.ts | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/cli-tools/src/logger.ts b/packages/cli-tools/src/logger.ts index 6ad30997f..a7165acdc 100644 --- a/packages/cli-tools/src/logger.ts +++ b/packages/cli-tools/src/logger.ts @@ -4,6 +4,7 @@ const SEPARATOR = ', '; let verbose = false; let disabled = false; +let hidden = false; const formatMessages = (messages: Array) => chalk.reset(messages.join(SEPARATOR)); @@ -35,6 +36,8 @@ const error = (...messages: Array) => { const debug = (...messages: Array) => { if (verbose && !disabled) { console.log(`${chalk.gray.bold('debug')} ${formatMessages(messages)}`); + } else { + hidden = true; } }; @@ -58,6 +61,8 @@ const enable = () => { disabled = false; }; +const hasDebugMessages = () => hidden; + export default { success, info, @@ -67,6 +72,7 @@ export default { log, setVerbose, isVerbose, + hasDebugMessages, disable, enable, }; diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts index bec0006d8..978c79f85 100644 --- a/packages/cli/src/index.ts +++ b/packages/cli/src/index.ts @@ -30,7 +30,7 @@ const handleError = (err: Error) => { if (err.stack) { logger.log(err.stack); } - if (!program.opts().verbose) { + if (!program.opts().verbose && logger.hasDebugMessages()) { logger.info( chalk.dim( `Run CLI with ${chalk.reset('--verbose')} ${chalk.dim(