-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(ajvResolver): reduce bundle size #523
Conversation
Size Change: -109 kB (-84%) 🏆 Total Size: 20.4 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh wow almost 100% save, awesome!
@bluebill1049 this is a breaking change that should be mentioned in the changelog |
@ilteoood Can you elaborate? There is no breaking changes here. It's mentioned in the release note |
IMO this should be listed in the breaking changes, as it requires some actions to be done on the user side in order to upgrade smoothly. If it was just a "performance improvement", I should be able to upgrade without doing any action, right? But this seems not to be the case, since now I need to include both |
Alright, I'll update the release notes. Just wanted to clarify that |
@jorisre you are completely right, but as this has been changed it should be explicitly written in the changelog. Just to warn the user that he should take care of this starting now 😄 |
Done ✅ |
No description provided.