Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/yup silently fail #327

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Fix/yup silently fail #327

merged 4 commits into from
Jan 18, 2022

Conversation

jorisre
Copy link
Member

@jorisre jorisre commented Jan 18, 2022

No description provided.

@jorisre jorisre requested a review from bluebill1049 January 18, 2022 08:37
bluebill1049
bluebill1049 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! perhaps this could be a minor update?

@jorisre
Copy link
Member Author

jorisre commented Jan 18, 2022

LGTM! perhaps this could be a minor update?

yep, I'll open a PR for the v1 as well

@bluebill1049
Copy link
Member

thanks @jorisre 🙏

@github-actions
Copy link
Contributor

Size Change: +534 B (+2%)

Total Size: 23.6 kB

Filename Size Change
yup/dist/yup.js 620 B +13 B (+2%)
yup/dist/yup.modern.js 561 B +13 B (+2%)
yup/dist/yup.module.js 634 B +12 B (+2%)
yup/dist/yup.umd.js 723 B +15 B (+2%)
zod/dist/zod.js 687 B +124 B (+22%) 🚨
zod/dist/zod.modern.js 632 B +117 B (+23%) 🚨
zod/dist/zod.module.js 704 B +121 B (+21%) 🚨
zod/dist/zod.umd.js 789 B +119 B (+18%) ⚠️
ℹ️ View Unchanged
Filename Size
class-validator/dist/class-validator.js 514 B
class-validator/dist/class-validator.modern.js 476 B
class-validator/dist/class-validator.module.js 539 B
class-validator/dist/class-validator.umd.js 617 B
computed-types/dist/computed-types.js 409 B
computed-types/dist/computed-types.modern.js 344 B
computed-types/dist/computed-types.module.js 424 B
computed-types/dist/computed-types.umd.js 503 B
dist/resolvers.js 313 B
dist/resolvers.module.js 325 B
dist/resolvers.umd.js 412 B
io-ts/dist/io-ts.js 1.26 kB
io-ts/dist/io-ts.modern.js 1.1 kB
io-ts/dist/io-ts.module.js 1.14 kB
io-ts/dist/io-ts.umd.js 1.39 kB
joi/dist/joi.js 592 B
joi/dist/joi.modern.js 492 B
joi/dist/joi.module.js 610 B
joi/dist/joi.umd.js 698 B
nope/dist/nope.js 345 B
nope/dist/nope.modern.js 329 B
nope/dist/nope.module.js 365 B
nope/dist/nope.umd.js 434 B
superstruct/dist/superstruct.js 302 B
superstruct/dist/superstruct.modern.js 314 B
superstruct/dist/superstruct.module.js 319 B
superstruct/dist/superstruct.umd.js 404 B
typanion/dist/typanion.js 323 B
typanion/dist/typanion.modern.js 313 B
typanion/dist/typanion.module.js 336 B
typanion/dist/typanion.umd.js 418 B
vest/dist/vest.js 472 B
vest/dist/vest.modern.js 380 B
vest/dist/vest.module.js 436 B
vest/dist/vest.umd.js 562 B

compressed-size-action

@jorisre jorisre merged commit 83f3397 into master Jan 18, 2022
@jorisre jorisre deleted the fix/yup-silently-fail branch January 18, 2022 08:51
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.8.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluebill1049 bluebill1049 bluebill1049 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisre @bluebill1049