Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] Tabbing away from date picker results in keyboard trap in Safari, Edge/IE #937

Closed
backwardok opened this issue Jan 3, 2018 · 1 comment
Closed

[a11y] Tabbing away from date picker results in keyboard trap in Safari, Edge/IE #937

backwardok opened this issue Jan 3, 2018 · 1 comment
Labels
accessibility Anything related to ensuring *everybody* can use react-dates <3 bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D

Comments

@backwardok
Copy link
Contributor

For both the DateRangePicker and the SingleDatePicker, if you tab to the date picker and then try to tab to the next thing after it, tab focus is reset to the top of the page and you're stuck in a keyboard trap.

Steps to reproduce:

  1. Open one of the examples (DateRangePicker or SingleDatePicker) using Safari or Edge
  2. Tab to the date picker (note you'll go past the README link and the wrapper source link)
  3. Tab out of the date picker

What's expected:
Next tab goes to Show Info button

What happens:
Next tab goes back to README link

Note that this works fine in Chrome, FF

Tested on Safari, Edge, IE11, Chrome (in Windows and Mac), FF (in Windows and Mac), Opera (in Windows)
@backwardok backwardok added the bug Oh no, something's broken :-( label Jan 3, 2018
@ljharb ljharb added the pull request wanted This is a great way to contribute! Help us out :-D label Jan 3, 2018
@backwardok backwardok added the accessibility Anything related to ensuring *everybody* can use react-dates <3 label Jan 3, 2018
@backwardok backwardok mentioned this issue Apr 24, 2018
Merged
@majapw majapw mentioned this issue Jun 15, 2018
Merged
@backwardok
Copy link
Contributor Author

This issue was fixed a while back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Anything related to ensuring *everybody* can use react-dates <3 bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @backwardok