Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize search performance #586

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Jan 4, 2021

fix #564

修改了 getLabeledValue 里面的 find 改为了 Map 获取。

影响范围:

getLabeledValue 的 prevValue 改为了 prevValueMap

toInnerValue 返回值 变成了两个参数 [RawValueType[], Map<RawValueType, LabelValueType>]

toOuterValues 的 prevValue 改为了 prevValueMap

@zombieJ 看看其他组件有没有用到,有没有什么影响?

@vercel
Copy link

vercel bot commented Jan 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/dt8dbkbw2
✅ Preview: https://select-git-optimize-search-performance.react-component.now.sh

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #586 (49c6018) into master (e73d080) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage   99.27%   99.27%   -0.01%     
==========================================
  Files          20       20              
  Lines         967      965       -2     
  Branches      324      321       -3     
==========================================
- Hits          960      958       -2     
  Misses          6        6              
  Partials        1        1              
Impacted Files Coverage Δ
src/interface/generator.ts 100.00% <ø> (ø)
src/generate.tsx 99.67% <100.00%> (ø)
src/hooks/useCacheOptions.ts 100.00% <100.00%> (ø)
src/utils/commonUtil.ts 100.00% <100.00%> (ø)
src/utils/valueUtil.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73d080...49c6018. Read the comment docs.

@kerm1it kerm1it requested review from zombieJ and afc163 January 4, 2021 06:09
@zombieJ
Copy link
Member

zombieJ commented Jan 4, 2021

rc-tree-select 有复用过 rc-select 的方法,需要确认一下不会 break 掉。

@kerm1it
Copy link
Member Author

kerm1it commented Jan 4, 2021

rc-tree-select 有复用过 rc-select 的方法,需要确认一下不会 break 掉。

本地编译了一下,点了一下,正常,测试也全部通过。

@kerm1it
Copy link
Member Author

kerm1it commented Jan 4, 2021

你可以在本地再试试,double check 一下

@zombieJ
Copy link
Member

zombieJ commented Jan 4, 2021

@@ -22,7 +22,7 @@ export default function useCacheOptions<
map.set(value, item);
});
return map;
}, [values, options]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当时为啥要把 values 作为 cache 条件?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不知道是咋了,今天看的时候才发现没有用到,😂

@zombieJ
Copy link
Member

zombieJ commented Jan 4, 2021

coverage 看起来掉了

@kerm1it
Copy link
Member Author

kerm1it commented Jan 4, 2021

是的,代码量减少了

@kerm1it
Copy link
Member Author

kerm1it commented Jan 4, 2021

需要确认的是,除了 tree-select 还有没有其他组件用到了这里的方法?我再去试试,不然害怕发个 patch 版本,有组件挂掉了?

@zombieJ
Copy link
Member

zombieJ commented Jan 5, 2021

可以 npm link 到 antd 里,然后跑一边 test。过了就可以发了~

@kerm1it
Copy link
Member Author

kerm1it commented Jan 5, 2021

antd 里面测试有问题

@kerm1it
Copy link
Member Author

kerm1it commented Jan 5, 2021

antd 里面测试有问题

把编译后的文件复制到 antd 里面后好了,全部通过。

@zombieJ zombieJ merged commit d532107 into master Jan 6, 2021
@zombieJ zombieJ deleted the optimize-search-performance branch January 6, 2021 02:14
@zombieJ
Copy link
Member

zombieJ commented Jan 6, 2021

我发个 minor 版本,antd 也升一下哈~~

@zombieJ
Copy link
Member

zombieJ commented Jan 6, 2021

+ rc-select@12.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

搜索时明显的性能问题及建议
2 participants