Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to v1 stable #723

Closed
3 of 9 tasks
ericvicenti opened this issue Mar 17, 2017 · 34 comments
Closed
3 of 9 tasks

Road to v1 stable #723

ericvicenti opened this issue Mar 17, 2017 · 34 comments

Comments

@ericvicenti
Copy link
Contributor

ericvicenti commented Mar 17, 2017

For the first release, lets focus on API sanity and stability, rather than adding every feature that people have requested.

After v1:

Lets aim to reach stability by mid-April!

@chandu0101
Copy link

any chance to get this #691 in v1 ..

@ericvicenti
Copy link
Contributor Author

@chandu0101, yep, just added it! I'm still searching around for high-pri issues

@migueloller
Copy link

@ericvicenti is #175 a high priority for v1?

@jakecraige
Copy link

I'd second #175 / #124 being part of 1.0. There's a large amount of ceremony around having an individual screen within a StackNavigator present from the bottom up that seems like a fairly core feature that many would find useful.

@nihgwu
Copy link

nihgwu commented Mar 18, 2017

@ericvicenti what about #271 debounce action reduce
and as I've said in #271, we shouldn't override custom key, or we can't find specific screen via key as it could be override, per #691 and NavigationActions.back('key')

@migueloller
Copy link

@nihgwu, I believe #135, which @ericvicenti included in the list above, would solve that problem.

@cychiuae
Copy link

I believe #527 is important too

@nihgwu
Copy link

nihgwu commented Mar 18, 2017

@migueloller sorry I didn't notice that before

@nihgwu
Copy link

nihgwu commented Mar 18, 2017

@cychiuae but #527 has been resolved, forget to close it though

@cychiuae
Copy link

@nihgwu someone said he still got the issue with master

@TomAtterton
Copy link

@ericvicenti I've noticed you still haven't added #175 / #124 / #690 / #232 The issue of controlling transitions of individual screens seems to be a high priority issue.

@getnashty
Copy link

+1 the need for #175.

@nehvaleem
Copy link

+1 need for #175

@nascode
Copy link

nascode commented Apr 4, 2017

A better way to configure screen transitions is needed for react-navigation to be competitive with other solution.

+1 for #175

@aranda-adapptor
Copy link

Perhaps #802 (Ability to "replace" screens in the stack navigator) should be on this list?

@ragnorc
Copy link

ragnorc commented Apr 6, 2017

+1 for #175 / #707 / #770

computerjazz added a commit to async-la/ttn-mobile that referenced this issue Apr 6, 2017
christopherdro pushed a commit to async-la/ttn-mobile that referenced this issue Apr 6, 2017
@lashae
Copy link

lashae commented Apr 8, 2017

@ericvicenti :
...
Lets aim to reach stability by mid-April!

We are just one week away from mid-April and it seems that all of the referenced issues are still open. I guess mid-April deadline is not realistic so far.

Is there any new ETA for the stable version?

@ericvicenti
Copy link
Contributor Author

The most important thing right now is for us to focus on stability so that people's apps are production-ready.

I think #124 and #175 are important for the long-term success of the library, but these are invasive and risky changes. We are trying to stabilize the library, and these features would require us to rip it up. If you're interested in highly-customized animations, you can of course use Transitioner directly, or you can find a third-party library that takes a navigation prop.

For those interested in an easy way to configure some screens as a modal and others as a card (#707 #770 #690 #232), you may find this workaround handy. I think it would break a lot of things if we tried to implement it differently. If anybody has ideas for a different implementation, feel free to open up a new issue and we can discuss. Maybe there is an easier way that I'm not seeing.

Replace functionality (#802) is also a pretty common request, and I think we could accomplish it by adding a key to the navigation action- you'd just pass the current key in order to replace. It seems that #271 would also get solved by #135.

@lashae, I won't make any more promises on timeline, but if you have any important fixes for your app, ping me and I'll help you merge them!

@charlle
Copy link

charlle commented Apr 13, 2017

@ericvicenti The screen life cycle events proposed in #51 are necessary to manage Scene updates on Back, to close and open web sockets / event listeners. Are there proposed work arounds?

@ericvicenti
Copy link
Contributor Author

@charlle, at the moment you can use controlled navigators, (see the redux example). When you explicitly provide the navigation.state, you can see when it changes and do things at that time. But I agree that #51 is very high-pri

@grabbou
Copy link

grabbou commented Apr 13, 2017

From my perspective, #88 would be great. I could work on it we can make it into next release candidate.

@DaleLJefferson
Copy link

Animated replace is an important issue for us. #351

This was referenced Apr 25, 2017
@grabbou
Copy link

grabbou commented Apr 26, 2017

We are quite settled on the initial list of features to support in v1 release. If you'd like to suggest more improvements, feel free to visit #1263 where we are discussing things to go into second stable release (namely v2)

@boliveira
Copy link

I think #706 should be in the list for v1.

@MovingGifts
Copy link

Almost 2 months in past the mid-April v1 estimate. Any status updates?

@luco
Copy link

luco commented Jun 25, 2017

+1 for #707 . I think adding a mode for each scene it's a must.

@timwangdev
Copy link

Expecting release a new beta version for all the issues are fixed in master.

@rpopovici
Copy link

rpopovici commented Aug 17, 2017

I opened several PRs. Is anyone checking this stuff?

@spencercarli
Copy link
Member

@rpopovici working on it - project went quiet for a while but we're playing catch up and trying to get things sorted out. Appreciate all the PRs you've opened - we'll get to them!

@dantman
Copy link

dantman commented Sep 28, 2017

@rabrenio Could you add a feature request for that instead of just a comment in the v1 issue.

@kelset
Copy link

kelset commented Sep 28, 2017

Closing this issue in favour of #2585.

@kelset kelset closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests