-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dialog] Dependencies update #800
Comments
Are there any breaking changes that you know of? Don't see an updated |
That was really a very internal change not affecting external behavior at all, but in the same time greatly decreasing complexity of Lock activation. What you are looking for:
The actual change can be found here - theKashey/focus-lock#24 |
Thanks @theKashey, on my list to review this weekend👍 |
Hi @chaance -- is there any update that you could share? If there's something I can do to help please let me know. Thank you. |
Released in 0.15.2 |
Enhancement
@reach/dialog internally relies on a
react-focus-lock
dependency library, which was recently updated to a new version 2.5.1.There was an existing performance issue with this library and it's dependency
focus-lock
in the previous version.They've found it, improved on it and it has upgraded overall performance of the focus lock feature. Just wanted to point that out and try to get this dependency bumped, rather sooner than later, thank you.
The text was updated successfully, but these errors were encountered: