Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Dependencies update #800

Closed
kuzmanovicatwork opened this issue May 25, 2021 · 5 comments · Fixed by #813
Closed

[Dialog] Dependencies update #800

kuzmanovicatwork opened this issue May 25, 2021 · 5 comments · Fixed by #813
Labels
Status: Awaiting Response Requested and awaiting a response from the issue creator Type: Enhancement General improvements or suggestions

Comments

@kuzmanovicatwork
Copy link

Enhancement

@reach/dialog internally relies on a react-focus-lock dependency library, which was recently updated to a new version 2.5.1.
There was an existing performance issue with this library and it's dependency focus-lock in the previous version.

They've found it, improved on it and it has upgraded overall performance of the focus lock feature. Just wanted to point that out and try to get this dependency bumped, rather sooner than later, thank you.

@chaance
Copy link
Member

chaance commented Jun 6, 2021

Are there any breaking changes that you know of? Don't see an updated CHANGELOG for either react-focus-lock or focus-lock libs, no github release notes, and am not 100% clear what I need to look for here. cc @theKashey

@chaance chaance added Status: Awaiting Response Requested and awaiting a response from the issue creator Type: Enhancement General improvements or suggestions labels Jun 6, 2021
@theKashey
Copy link
Contributor

That was really a very internal change not affecting external behavior at all, but in the same time greatly decreasing complexity of Lock activation.
Look like changelog is a little outdated yet again - manually rebuilt and pushed changes.

What you are looking for:

  • react-focus-lock > 2.5.1 (just updating dependency)
  • or focus-lock > 0.9.0 (source of the fix)

The actual change can be found here - theKashey/focus-lock#24

@chaance
Copy link
Member

chaance commented Jun 9, 2021

Thanks @theKashey, on my list to review this weekend👍

@andrewnystrom
Copy link

Hi @chaance -- is there any update that you could share? If there's something I can do to help please let me know. Thank you.

@chaance
Copy link
Member

chaance commented Jun 28, 2021

Released in 0.15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Response Requested and awaiting a response from the issue creator Type: Enhancement General improvements or suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants