Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Class Refactoring #94

Open
rdoddanavar opened this issue Apr 23, 2022 · 0 comments
Open

Model Class Refactoring #94

rdoddanavar opened this issue Apr 23, 2022 · 0 comments
Assignees
Labels
pre-processing Simulation I/O & data management refactoring (refactoring)

Comments

@rdoddanavar
Copy link
Owner

rdoddanavar commented Apr 23, 2022

  • Formalize input, output data for models:
    • Set explicit list of input, output variables in model class definition
    • Use references instead of pointers for input variables
  • Other refactoring:
    • Rename engine model class to propulsion
    • Formalize lookup table data for model classes:
      • independent numpy array(s)
      • dependent numpy array(s)
  • Use proper conventions for python packing and import structure
    • Ex. Instead of import util_yaml use import util.yaml
    • Requires renaming of files
    • Consider using proper __init.py__ files
@rdoddanavar rdoddanavar added refactoring (refactoring) pre-processing Simulation I/O & data management labels Apr 23, 2022
@rdoddanavar rdoddanavar self-assigned this Apr 23, 2022
@rdoddanavar rdoddanavar changed the title Restructure Global State Variables Restructure global state variables Apr 23, 2022
@rdoddanavar rdoddanavar changed the title Restructure global state variables Restructure State & Telemetry Sep 9, 2024
@rdoddanavar rdoddanavar changed the title Restructure State & Telemetry Model Class Refactoring Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-processing Simulation I/O & data management refactoring (refactoring)
Projects
None yet
Development

No branches or pull requests

1 participant