Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@rdfjs/types 1.1.1 exported to npm as empty package #49

Closed
Renegade334 opened this issue Sep 17, 2024 · 12 comments · Fixed by #52
Closed

@rdfjs/types 1.1.1 exported to npm as empty package #49

Renegade334 opened this issue Sep 17, 2024 · 12 comments · Fixed by #52

Comments

@Renegade334
Copy link

https://www.npmjs.com/package/@rdfjs/types/v/1.1.1?activeTab=code

The latest @rdfjs/types package has just been pushed to npm... without any types!

Understandably, this is causing some ecosystem issues... 😉

(@rdfjs @tpluscode et al.)

@jeswr
Copy link
Contributor

jeswr commented Sep 17, 2024

cc @matthieubosquet - I suspect this comes from #47

@tpluscode
Copy link
Contributor

Good grief. Fixing ASAP

@matthieubosquet
Copy link
Contributor

I am not familiar with the @changeset/cli and I am surprised that it is inconsistent with npm pack.

Note that when I run npm pack locally on the up to date master branch of this repo, I still get the intended files:

Screenshot 2024-09-17 at 16 33 46

I notice a lot of warnings on the release action run.

I looked up changeset but none of the commands gave me anything explicit as to how the package is created.

@tpluscode
Copy link
Contributor

It should be consistent, of course, and I'm surprised we ran into that issue. Investigating now

@tpluscode
Copy link
Contributor

The warnings show we're using an old version of the changesets action. Could be the reason for failure

@tpluscode
Copy link
Contributor

I unpublished the 1.1.1 version from NPM

@matthieubosquet
Copy link
Contributor

I also tried a npm publish --dry-run which works as expected:

Screenshot 2024-09-17 at 17 02 58

So, a manual publish from local should work if you can do that @tpluscode (and thank you for jumping on this so promptly).

@matthieubosquet
Copy link
Contributor

Apparently the issue is with yarn. When I run yarn pack, the declaration files are not included.

There are open issues on GitHub about yarn pack behaving inconsistent with npm pack.

@tpluscode
Copy link
Contributor

That's an interesting find. yarn v1 is EOL anyway, so we might just switch to npm

@matthieubosquet
Copy link
Contributor

matthieubosquet commented Sep 17, 2024

@tpluscode I found a file pattern that works with both yarn and npm: "**/*.d.ts" (see PR #50, requires deleting v1.1.1 tag and release).

I prefer using npm but it looks like changeset is for yarn and I don't know if others have preferences or know of tooling that they would like to use in the release process.

I personally use a very simple action that triggers on GitHub Release to publish my packages to npm.

@tpluscode
Copy link
Contributor

Changesets do not depend on yarn and will use the correct package manager used in a project (npm or pnpm, where applicable). In fact, I think that npm is the default fallback.

@matthieubosquet
Copy link
Contributor

matthieubosquet commented Sep 17, 2024

Changesets do not depend on yarn and will use the correct package manager used in a project (npm or pnpm, where applicable). In fact, I think that npm is the default fallback.

That's great to know (and makes way more sense)!
I was confused because all the changeset action examples use yarn. That makes it easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants