Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build script #116

Open
eatyourpeas opened this issue Oct 21, 2024 · 0 comments
Open

build script #116

eatyourpeas opened this issue Oct 21, 2024 · 0 comments
Labels
consistency Not strictly a bug, but an implementation could be made clearer

Comments

@eatyourpeas
Copy link
Member

The npm run build build script has been updated in newer versions of rollup.
Currently this is what we have:
"build": "ROLLUP_WATCH=false rollup -c --bundleConfigAsCjs",
Now that we have upgraded rollup following a reported security vulnerability in Rollup, it should be:
build”: “ROLLUP -w -c --bundleConfigAsCjs

What we have seems to work without any warnings at the moment
Thanks to Caroline Kirkhope at System C for noticing this
@eatyourpeas eatyourpeas added the consistency Not strictly a bug, but an implementation could be made clearer label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consistency Not strictly a bug, but an implementation could be made clearer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eatyourpeas