Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No passwords found in config file #1

Closed
broizter opened this issue Nov 20, 2020 · 3 comments
Closed

No passwords found in config file #1

broizter opened this issue Nov 20, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@broizter
Copy link

passwordcheck v1.0.1

When running this utility on a config file where the password isn't generated by rclone the output can be a bit confusing. Without using -verbose this is what you get:

No passwords found in config file - did you use the right file?

But if you run it with -verbose it's a bit more clear what is actually happening:

###########: obscured password password = "####################" was not generated by rclone: illegal base64 data at input byte 7

@ncw
Copy link
Member

ncw commented Nov 20, 2020

Hmm, yes that wording isn't quite right is it.

The tool is discarding passwords which can't have been generated by rclone config but not counting them as found passwords.

I'll have a think.

@ncw ncw added the enhancement New feature or request label Nov 20, 2020
@ncw
Copy link
Member

ncw commented Nov 22, 2020

I've added a stats block like this

found 269 remote definitions
found 54 passwords generated by rclone config which need checking
ignored 11 passwords not generated by rclone config
ignored 14 passwords less than 64 bits

which will be printed after the tool has parsed the config file which should make it clearer.

I've also changed the message to

No passwords to check found in config file - did you use the right file?

@ncw ncw closed this as completed in 4dce5de Nov 22, 2020
@ncw
Copy link
Member

ncw commented Nov 22, 2020

This was released in v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants