Add events on the calculator #3
Conversation
There was a problem hiding this comment.
Status: Approved 🟢 🥇 💯
Hey @rbd3 👋
Great work on implementing the events. Your project is complete. 😊
There is nothing else to say about your project. 👍
Highlights 🥇
✔️ Descriptive PR Title
✔️ Descriptive PR Summary
✔️ Following Gitflow
✔️ Following Requirements
✔️ Great work on implementing the logic especially modulus 👍
✔️ Great work on using State and Props 😊
✔️ App is working as expected 🥇
Optional
All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.
Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -48,5 +48,5 @@ input[type='text']::placeholder { | |||
| } | |||
There was a problem hiding this comment.
[OPTIONAL]
- It would be nice if you make your own logo of your name and put that in the readme file at the top to present yourself as a brand in the job market or tech industry to catch the recruiters' eyes 👍
Change made:
👉 Create a new directory called logic
👉 copy operate.js and operation.js in the logic folder.
👉 implement a click event handler for all buttons.