Add component #2
Conversation
There was a problem hiding this comment.
Hi @rbd3 👋👋👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights✅✅✅
- Project is professionally documented👍.
-
componentsdirectory has been created that contains aCakculator.jsfile👍. - Functional components is used in
calculator.js👍.
Required Changes ♻️
- Nice job so far😉. Currently, your project still has some boilerplate files and codes😉.
But let's not forget that it is a requirement in this milestone that all boiler plate from CRA is deleted (texts, files, images, styles etc). This will avoid any form of confusion in the future😉.
- Let's also ensure the
calculator.jshas atleast one child components😉. apart from this being a requirement, code splitting makes our code base easily maintainable and understandable. there are several ways your calculator component app can be split😉. You can make thescreenone component and thebuttonsanother components😉.
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Status: Approved 🟢 🟢 🟢
Hi @rbd3,
Good job working on the changes highlighted by the previous reviewer 👍🏽
Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉
Highlights:
✅ You used Gitflow correctly 👍🏽
✅ The Linter checks passed 👍🏽
✅ Created components correctly as expected 👍🏽
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <div className="screen"> | ||
| <input type="text" placeholder="0" /> | ||
| </div> |
There was a problem hiding this comment.
Suggested Changes
- The calculator result view's height is too high and does not match the original design. What if you could reduce the height to match the original design?
This is not much of a big change and hence I decided to make a suggestion, I highly recommend you work on it please 👍🏽
The Original Design
Your Design
Change made 🥇
👉 Delete all the boilerplate from Create React App
👉 Create a new directory called components.
👉 Create a calculator component with style