Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add starring repository #59

Closed
mabdh opened this issue Jan 12, 2022 · 3 comments · Fixed by #73
Closed

feat: add starring repository #59

mabdh opened this issue Jan 12, 2022 · 3 comments · Fixed by #73
Labels
enhancement New feature or request

Comments

@mabdh
Copy link
Member

mabdh commented Jan 12, 2022

Is your feature request related to a problem? Please describe.
I want to star/bookmark a resource to be revisited again later and able to fetch all of my starred resources.

Describe the solution you'd like

  • We need a new table in DB with this schema
starring type Sample Value
id (PK) SERIAL 1
user_id (FK) UUID 11234-4214214
asset_id (FK) UUID 11234-4214214
created_at TIMESTAMP 12345667
updated_at TIMESTAMP 12345667
  • We need a new starring repository layer
@mabdh mabdh added the enhancement New feature or request label Jan 12, 2022
@mabdh mabdh linked a pull request Jan 27, 2022 that will close this issue
@mabdh
Copy link
Member Author

mabdh commented Jan 27, 2022

Considering we already have assets table in postgres, do you guys think it will be better to remove asset_urn and asset_type and replace them with asset_id instead? @StewartJingga @ravisuhag

@ravisuhag
Copy link
Member

assets_urn would still need to be there, right? That is the only way meteor identifies the assets, right. Without this, It won't know about Columbus asset_id to update assets.

@mabdh
Copy link
Member Author

mabdh commented Jan 27, 2022

We still use asset_urn and asset_type on API params.

But inside we can resolve the asset_id via asset_table.

My concern is
Unique information of an asset in stars table would be a tuple (asset_urn, asset_type). Because asset_urn (at least for now) is not globally unique.

If we just use asset_id in stars table, we only have a single unique information about an assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants