From b18d570c1c1904375344cba73ea4cb06cfc4846d Mon Sep 17 00:00:00 2001 From: Suhas Karanth Date: Thu, 27 Oct 2022 15:18:41 +0530 Subject: [PATCH] feat: allow feature_table as an asset type (#176) --- core/asset/type.go | 12 +++++++----- internal/server/v1beta1/type_test.go | 4 ++++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/core/asset/type.go b/core/asset/type.go index 371b22b5..f0d23743 100644 --- a/core/asset/type.go +++ b/core/asset/type.go @@ -1,10 +1,11 @@ package asset const ( - TypeTable Type = "table" - TypeJob Type = "job" - TypeDashboard Type = "dashboard" - TypeTopic Type = "topic" + TypeTable Type = "table" + TypeJob Type = "job" + TypeDashboard Type = "dashboard" + TypeTopic Type = "topic" + TypeFeatureTable Type = "feature_table" ) // AllSupportedTypes holds a list of all supported types struct @@ -13,6 +14,7 @@ var AllSupportedTypes = []Type{ TypeJob, TypeDashboard, TypeTopic, + TypeFeatureTable, } // Type specifies a supported type name @@ -26,7 +28,7 @@ func (t Type) String() string { // IsValid will validate whether the typename is valid or not func (t Type) IsValid() bool { switch t { - case TypeTable, TypeJob, TypeDashboard, TypeTopic: + case TypeTable, TypeJob, TypeDashboard, TypeTopic, TypeFeatureTable: return true } return false diff --git a/internal/server/v1beta1/type_test.go b/internal/server/v1beta1/type_test.go index d7bf4a70..1fb022f3 100644 --- a/internal/server/v1beta1/type_test.go +++ b/internal/server/v1beta1/type_test.go @@ -74,6 +74,10 @@ func TestGetTypes(t *testing.T) { Name: "topic", Count: 30, }, + { + Name: "feature_table", + Count: 0, + }, }, }