Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test sample RayCluster YAMLs to catch invalid or out of date ones #642

Closed
davidxia opened this issue Oct 18, 2022 · 2 comments · Fixed by #678
Closed

Test sample RayCluster YAMLs to catch invalid or out of date ones #642

davidxia opened this issue Oct 18, 2022 · 2 comments · Fixed by #678
Assignees
@kevin85421
Labels
P1 Issue that should be fixed within a few weeks

Comments

@davidxia
Copy link
Contributor

There are lots of sample RayCluster YAMLs in this repo. They are at risk of falling out of date with CRD schemas or best practices. Testing the sample YAMLs will help.

motivation from this issue
@kevin85421
Copy link
Member

Good idea. The sample YAML files can be easily tested with #605. I can work on this after the test framework is merged.

@davidxia
Copy link
Contributor Author

@kevin85421 thanks so much!

@kevin85421 kevin85421 self-assigned this Oct 24, 2022
@kevin85421 kevin85421 added the P1 Issue that should be fixed within a few weeks label Oct 24, 2022
This was referenced Nov 3, 2022
Merged
Closed
@kevin85421 kevin85421 mentioned this issue Nov 14, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin85421 kevin85421

Labels
P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] Test sample RayCluster YAMLs to catch invalid or out of date ones kevin85421/kuberay
2 participants
@davidxia @kevin85421