From 0ac9942dd95e4c1e4f74d08803d62ad86ede1828 Mon Sep 17 00:00:00 2001 From: Chi-Sheng Liu Date: Thu, 6 Feb 2025 10:26:46 +0800 Subject: [PATCH] [CI] Fix lint error (require-error) (#2931) Signed-off-by: Chi-Sheng Liu --- kubectl-plugin/pkg/cmd/version/version_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/kubectl-plugin/pkg/cmd/version/version_test.go b/kubectl-plugin/pkg/cmd/version/version_test.go index 600fd3fccf7..288d65cbd2d 100644 --- a/kubectl-plugin/pkg/cmd/version/version_test.go +++ b/kubectl-plugin/pkg/cmd/version/version_test.go @@ -8,6 +8,7 @@ import ( "github.com/ray-project/kuberay/kubectl-plugin/pkg/util" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" "k8s.io/cli-runtime/pkg/genericclioptions" "k8s.io/client-go/kubernetes" cmdtesting "k8s.io/kubectl/pkg/cmd/testing" @@ -20,10 +21,10 @@ func TestRayVersionCheckContext(t *testing.T) { testContext := "test-context" kubeConfigWithCurrentContext, err := util.CreateTempKubeConfigFile(t, "my-fake-context") - assert.NoError(t, err) + require.NoError(t, err) kubeConfigWithoutCurrentContext, err := util.CreateTempKubeConfigFile(t, "") - assert.NoError(t, err) + require.NoError(t, err) tests := []struct { name string @@ -76,7 +77,7 @@ func TestRayVersionCheckContext(t *testing.T) { if tc.expectError != "" { assert.Equal(t, tc.expectError, err.Error()) } else { - assert.NoError(t, err) + require.NoError(t, err) } }) } @@ -147,7 +148,7 @@ func TestRayVersionRun(t *testing.T) { var buf bytes.Buffer err := fakeVersionOptions.Run(context.Background(), fClient, &buf) - assert.NoError(t, err) + require.NoError(t, err) assert.Equal(t, tc.expected, buf.String()) })