Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with v2.7.0 #157

Closed
p-linnane opened this issue Aug 26, 2024 · 3 comments
Closed

Build failure with v2.7.0 #157

p-linnane opened this issue Aug 26, 2024 · 3 comments

Comments

@p-linnane
Copy link

Hello 👋 . I'm a maintainer for the Homebrew project. While updating kew to v2.7.0, we are encountering a failure. Below is the error when running make:

  gcc -o kew src/obj/write_ascii.o src/obj/common_ui.o src/obj/sound.o src/obj/directorytree.o src/obj/soundcommon.o src/obj/search_ui.o src/obj/playlist_ui.o src/obj/player.o src/obj/soundbuiltin.o src/obj/mpris.o src/obj/playerops.o src/obj/utils.o src/obj/file.o src/obj/chafafunc.o src/obj/cache.o src/obj/songloader.o src/obj/playlist.o src/obj/term.o src/obj/settings.o src/obj/visuals.o src/obj/kew.o -L/usr/lib -lfreeimage -lpthread -lrt -pthread -lm -lglib-2.0 -L/home/linuxbrew/.linuxbrew/Cellar/glib/2.80.4/lib -L/home/linuxbrew/.linuxbrew/Cellar/chafa/1.14.2/lib -L/home/linuxbrew/.linuxbrew/Cellar/libvorbis/1.3.7/lib -L/home/linuxbrew/.linuxbrew/Cellar/opus/1.5.2/lib -L/home/linuxbrew/.linuxbrew/Cellar/fftw/3.3.10_1/lib -L/home/linuxbrew/.linuxbrew/Cellar/ffmpeg/7.0.2/lib -L/home/linuxbrew/.linuxbrew/Cellar/opusfile/0.12_1/lib -lavcodec -lavutil -lavformat -lswresample -lgio-2.0 -lgobject-2.0 -lchafa -lfftw3f -lopus -lopusfile -lvorbis -lvorbisfile -lglib-2.0 -latomic -pie -Wl,-z,relro
  /home/linuxbrew/.linuxbrew/opt/binutils/bin/ld: src/obj/sound.o: in function `createAudioDevice':
  sound.c:(.text+0x67b22): undefined reference to `displaySongNotification'
  /home/linuxbrew/.linuxbrew/opt/binutils/bin/ld: src/obj/kew.o: in function `notifySongSwitch':
  kew.c:(.text+0xdb2): undefined reference to `displaySongNotification'
  collect2: error: ld returned 1 exit status

Any assistance here is appreciated.

Relates to Homebrew/homebrew-core#182465.

@ravachol
Copy link
Owner

ravachol commented Aug 26, 2024

Hi, there was a missing #ifdef for people who don't have libnotify installed. It's added back in v2.7.1.

It's supposed to set USE_LIBNOTIFY 1 if you have libnotify installed and USE_LIBNOTIFY 0 if you don't.

@p-linnane
Copy link
Author

Confirming that v2.7.1 is working for us. Thanks for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@ravachol @p-linnane and others