Skip to content
This repository has been archived by the owner on Sep 30, 2022. It is now read-only.

Travis build fails #6

Closed
ejoerns opened this issue May 24, 2018 · 6 comments
Closed

Travis build fails #6

ejoerns opened this issue May 24, 2018 · 6 comments
Labels
bug

Comments

@ejoerns
Copy link
Member

ejoerns commented May 24, 2018 

$ tox-travis
tox-travis: command not found
@ejoerns ejoerns added the bug label May 24, 2018
@ejoerns
Copy link
Member Author

ejoerns commented May 24, 2018

targeted outdated branch. Thus no action needed

@ejoerns ejoerns closed this as completed May 24, 2018
@ejoerns
Copy link
Member Author

ejoerns commented May 24, 2018

And we can instantly recycle this one as Travis really fails (but with a different issue):

>       with aiohttp.Timeout(self.timeout):
E       AttributeError: module 'aiohttp' has no attribute 'Timeout'

@ejoerns ejoerns reopened this May 24, 2018
@Bastian-Krause
Copy link
Member

Bastian-Krause commented May 24, 2018 •
edited
Loading

aiohttp.Timeout was removed in aiohttp-3.0.0 (see changelog referencing PR #2348)

We should use the timeout keyword of aiohttp.ClientSession.get() instead as described here.

@Bastian-Krause
Copy link
Member

I will send a PR fixing this.

@Bastian-Krause
Copy link
Member

PR #7 and #9 are intended to fix this.

@ejoerns
Copy link
Member Author

ejoerns commented Mar 15, 2019

Fixed by #7 and #8

@ejoerns ejoerns closed this as completed Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejoerns @Bastian-Krause