-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perley Polyhedron Gridder literal interaction fails on Numba 0.51 #218
Comments
There seems to be some discussion around this topic in numba/numba#5411 (comment) |
It looks as if the strategy for handling this is to use SentryLiteralArgs: there's some documentation around this, but I don't find it obvious: https://numba.pydata.org/numba-doc/dev/developer/literal.html#inside-extensions |
I was doing that but I had to stop due to other work. I'm unsure what has changed in the literal type system. There were no deprecation warnings raised so I think this is a bonafide bug in the releases >=0.5.I also don't quite follow the documentation for SentryLiteralArgs. |
I don't think its a bug -- I think literals are an obscure feature that hasn't been fully fleshed out. If the use of SentryLiteralArgs is the prescribed method of resolving these issues, then they should be used. |
One possible way of resolving this is to revert the original PR and continue development in #219 until the issue is resolved. |
I've reverted the original PR in #220. All existing changes are preserved in #219. Sorry @bennahugo, I think some more work is required here. |
Fixed in #222 |
Description
In discussion with @bennahugo numba was pinned in #202 to <= 0.49.0 to avoid these failures.
This issue serves to document the issues on an upgrade to numba 0.51.0. The Perley Polyhedron Gridding code fails to compile.
What I Did
`$ py.test -s -vvv -k test_gridder_nondask` and output
This seems to be the most relevant part of the output.
@bennahugo, @JSKenyon Would either of you have the bandwidth to make a MRE and take it up with the numba team?
The text was updated successfully, but these errors were encountered: