Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to latest Azure container registry SDK #959

Open
1 task done
akashsinghal opened this issue Aug 1, 2023 · 6 comments · May be fixed by #1829
Open
1 task done

Migrate to latest Azure container registry SDK #959

akashsinghal opened this issue Aug 1, 2023 · 6 comments · May be fixed by #1829
Assignees
Milestone

Comments

@akashsinghal
Copy link
Collaborator

What would you like to be added?

Ratify’s Azure auth providers rely on a deprecated 2019 preview go sdk to authenticate with the ACR. We should refactor code and migrate to latest SDK.

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@yizha1 yizha1 added this to the v1.0.0-rc.7 milestone Aug 1, 2023
@akashsinghal
Copy link
Collaborator Author

@yizha1 we are blocked by this. Azure sdk for go has limitation on the Refresh Token Client not being exposed on latest sdk. We cannot upgrade to latest stable sdk until this is resolved. We will need to postpone this post GA

@yizha1
Copy link
Collaborator

yizha1 commented Aug 14, 2023

@akashsinghal Thanks for sharing this information. This means we need to keep using the current preview SDK, and figure out the upgrade path or other alternatives to solve this issue. We can discuss it further in the community meeting on 8/16/2023.

@akashsinghal akashsinghal modified the milestones: v1.0.0-rc.7, v1.0.0-rc.8 Aug 24, 2023
@susanshi susanshi modified the milestones: v1.0.0-rc.8, Future Aug 31, 2023
@susanshi
Copy link
Collaborator

Move to 1.1

@binbin-li binbin-li modified the milestones: Future, v1.4.0, v1.3.0 Jul 25, 2024
@susanshi
Copy link
Collaborator

susanshi commented Aug 1, 2024

Hi @akashsinghal , for new contributor to ramp up on this. Would you be able to include doc and src code links for the impact code path/user scenario. thanks!

@susanshi
Copy link
Collaborator

susanshi commented Aug 2, 2024

I believe the impacted code path are in azidentity and azureworkloadidentity. @akashsinghal to confirm if this currently cli or only the k8s scenario

@akashsinghal
Copy link
Collaborator Author

@susanshi this issue is tracking specifically the ACR SDK which is used only by oras workload identity auth provider. This issue is blocked. New versions of SDK do not expose only receiving refresh token for AAD token which is what ORAS requires as input for credential. Until a new version exposes a refresh client, we cannot proceed from Ratify side

oras-project/oras-go#476

@binbin-li binbin-li modified the milestones: v1.3.0, v1.4.0 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants