-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): use ratatui::crossterm in examples #1315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
force-pushed
the
jm/examples-imports
branch
from
August 10, 2024 02:16
064d5b5
to
a384a3c
Compare
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
We import from `ratatui::crossterm`` instead of crossterm directly in the examples to ensure that the version of the crossterm crate used is the same one as the one used by ratatui. This helps avoid compilation errors resulting from multiple versions of the same crate.
joshka
force-pushed
the
jm/examples-imports
branch
from
August 10, 2024 03:08
a384a3c
to
75c8de0
Compare
orhun
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We import from `ratatui::crossterm`` instead of crossterm directly in
the examples to ensure that the version of the crossterm crate used is
the same one as the one used by ratatui. This helps avoid compilation
errors resulting from multiple versions of the same crate.
Also avoids importing from the prelude in the examples.