Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(list): split up list.rs into smaller modules #1204

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

joshka
Copy link
Member

@joshka joshka commented Jun 27, 2024

No description provided.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 99.65665% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.4%. Comparing base (3e7458f) to head (9a24ba1).

Files Patch % Lines
src/widgets/list/state.rs 96.4% 3 Missing ⚠️
src/widgets/list/list.rs 98.9% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1204   +/-   ##
=====================================
  Coverage   94.4%   94.4%           
=====================================
  Files         62      65    +3     
  Lines      15048   15056    +8     
=====================================
+ Hits       14217   14225    +8     
  Misses       831     831           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka added Effort: Easy Something that should be pretty quick to fix Status: Review Needed PR needs a review / Issue needs buy-in from other maintainers / users labels Jun 27, 2024
@joshka
Copy link
Member Author

joshka commented Jul 18, 2024

ping @ratatui-org/maintainers

@joshka joshka merged commit e81663b into main Jul 18, 2024
33 checks passed
@joshka joshka deleted the jm/refactor-list branch July 18, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Easy Something that should be pretty quick to fix Status: Review Needed PR needs a review / Issue needs buy-in from other maintainers / users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants