feat: Better error messages for span! macro
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
approved these changes
May 13, 2024
Merged
kdheepak
pushed a commit
that referenced
this pull request
May 13, 2024
## 🤖 New release * `ratatui-macros`: 0.3.0 -> 0.3.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.1](v0.3.0...v0.3.1) - 2024-05-13 ### Added - Better error messages for `span!` macro ([#43](#43)) ### Fixed - downgrade ratatui to 0.26.2 ([#41](#41)) ### Other - Update authors to ratatui developers ([#44](#44)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, if a user accidentally uses
,as a separator when the first argument is a style, they'll will get a better compiler error message:This also updates the docstrings to reiterate that
,must be used for format specifier and;must be used for style.