Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify help.rs #27

Merged
merged 2 commits into from
Feb 12, 2024
Merged

refactor: simplify help.rs #27

merged 2 commits into from
Feb 12, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Feb 12, 2024

Removes the complex chain calls, and the skipping behavior.

@joshka
refactor: simplify help.rs
a735e01 
Removes the complex chain calls, and the skipping behavior.
@joshka joshka requested a review from kdheepak February 12, 2024 09:48
@joshka
Copy link
Member Author

joshka commented Feb 12, 2024

image

@kdheepak
Copy link
Contributor

kdheepak commented Feb 12, 2024 •
edited
Loading

In the previous implementation, when hitting ? in the table view, the help menu would open when the selection at the first entry corresponding to that mode. Do we not want to retain that behavior?

@joshka joshka mentioned this pull request Feb 12, 2024
Closed
3 tasks
kdheepak
kdheepak reviewed Feb 12, 2024
View reviewed changes
src/widgets/help.rs Outdated Show resolved Hide resolved
kdheepak
kdheepak approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@kdheepak kdheepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@kdheepak kdheepak merged commit 5d84d65 into main Feb 12, 2024
5 of 6 checks passed
@kdheepak kdheepak deleted the jm/help branch February 12, 2024 16:01
@kdheepak kdheepak mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdheepak kdheepak kdheepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshka @kdheepak