-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning message if domain yml file is not valid #8926
Conversation
Thanks for submitting a pull request 🚀 @samsucik will take a look at it as soon as possible ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🚀
Could you please share more details on how to replicate the issue - what was the invalid yaml syntax and what command did you run?
Please address the following items:
- swap to utility function
raise_warning
as in the comment - add a test in
tests/shared/core/test_domain.py
to replicate the issue and check that the correct warning is raised - add a changelog entry (the type should be
improvement
)
Let me know if you have any q's for me 👍
to raise a UserWarning instead of logging.warn()
…rasa into warn_domain_yml_invalid
test_domain_invalid_yml_in_folder()
pytest added to tests/shared/core/test_domain.py If there is anything missing, please ping me, @ancalita and @erohmensing |
data/test_domains/test_domain_from_directory1/domain_invalid.yml
Outdated
Show resolved
Hide resolved
ok, I am lost.
my black says
however, it suggests to change 79 other files on my pc. |
@ancalita maybe the black version is different? I installed "latest" which was at that time
What is your pipeline using? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
yaml syntax
Issue a logging warning if a domain file is invalid YAML syntax.
We at Deutsche Telekom encountered the issue that somebody put an invalid yaml file in our domain folder. The errors we got were just about missing intents in the domain. We expected to get some warning about the file being ignored due to invalid yaml though.
Status (please check what you already did):
black
(please check Readme for instructions)