Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Deprecation Warnings: Remove Policy deprecations #8880

Closed
4 tasks done
ancalita opened this issue Jun 15, 2021 · 3 comments · Fixed by #9119
Closed
4 tasks done

3.0 Deprecation Warnings: Remove Policy deprecations #8880

ancalita opened this issue Jun 15, 2021 · 3 comments · Fixed by #9119
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework maintenance:rasa-3.0/deprecation

Comments

@ancalita
Copy link
Member

ancalita commented Jun 15, 2021

Background
These warnings were found in:

  • rasa.core.policies.fallback.py:L66
"f""'{self.__class__.__name__}' is deprecated and will be removed ""
""in the future. It is recommended to use the 'RulePolicy' instead."""
  • rasa.core.policies.form_policy.py:L51
"f""'{FormPolicy.__name__}' is deprecated and will be removed in ""
 ""in the future. It is recommended to use the 'RulePolicy' instead."""
  • rasa.core.policies.mapping_policy.py:L49
"f""'{MappingPolicy.__name__}' is deprecated and will be removed in ""
""the future. It is recommended to use the 'RulePolicy' instead."""
  • rasa.core.policies.memoization.py:L87
"f""Please configure the max history in your configuration file, ""
f""currently 'max_history' is set to old default value of ""
f""'{max_history}'. If you want to have infinite max history ""
f""set it to 'None' explicitly. We will change the default value of ""
 f""'max_history' in the future to 'None'."","
  • rasa.core.policies.sklearn_policy.py:L124
"f""'{SklearnPolicy.__name__}' is deprecated and will be removed in ""
""the future. It is recommended to use the 'TEDPolicy' instead."""

Definition of Done

  • resolve warnings in 3.0 version
  • Removed the deprecated policies from the codebase.
  • Added a changelog entry for 3.0 saying we've removed the previously deprecated policies
  • Removed the references in the docs
@ancalita ancalita added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Jun 15, 2021
@TyDunn TyDunn added this to the 3.0 Rasa Open Source milestone Jun 15, 2021
@TyDunn TyDunn added effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. effort:research/1 and removed effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. labels Jul 9, 2021
@kedz
Copy link
Contributor

kedz commented Jul 9, 2021

@ancalita @JEM-Mosig @TyDunn TwoStageFallbackPolicy is listed as deprecated in our docs page, but does not have a deprecation warning in its constructor. Is this an oversight and should we also remove it from the code base along with these other deprecated policies?

@kedz
Copy link
Contributor

kedz commented Jul 9, 2021

Also it turns out TwoStageFallbackPolicy is a subclass of FallbackPolicy so I guess it has to go.

@TyDunn
Copy link
Contributor

TyDunn commented Jul 12, 2021

Is this an oversight?

I'd guess it was or maybe since it was subclass of FallbackPolicy, someone did not think it was necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework maintenance:rasa-3.0/deprecation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants