Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed group_id from Kafka Producer's Description #7601

Merged
merged 3 commits into from
Dec 29, 2020
Merged

Removed group_id from Kafka Producer's Description #7601

merged 3 commits into from
Dec 29, 2020

Conversation

b-quachtran
Copy link
Contributor

@b-quachtran b-quachtran commented Dec 18, 2020 •
edited
Loading

Proposed changes:

  • Removed group_id from Kafka Producer's Description

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@b-quachtran b-quachtran added the type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. label Dec 18, 2020
@rgstephens rgstephens merged commit 230a307 into master Dec 29, 2020
@rgstephens rgstephens deleted the remove_group_id_description branch December 29, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgstephens rgstephens rgstephens approved these changes

Assignees
No one assigned
Labels
type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-quachtran @rgstephens