Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack connector: implemented signing secret and updated docs #7186

Merged
merged 12 commits into from
Nov 8, 2020
Merged

slack connector: implemented signing secret and updated docs #7186

merged 12 commits into from
Nov 8, 2020

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Nov 5, 2020 •
edited
Loading

Proposed changes:

  • validate slack requests using signing secret
  • updated documentation page (old instructions were outdated, added screenshots)
  • moved slack tests into their own module (added new tests for signature at the bottom)

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo requested review from a team and joejuzl and removed request for a team November 5, 2020 09:20
@tmbo tmbo requested review from erohmensing and wochinge November 5, 2020 09:21
tmbo
tmbo commented Nov 5, 2020
View reviewed changes
@tmbo
Copy link
Member Author

tmbo commented Nov 5, 2020

@erohmensing added images to the slack docs, as it was very hard to follow them without. does this look sane?

@wochinge wochinge added this to the 2.1 Rasa Open Source milestone Nov 5, 2020
@tmbo tmbo changed the base branch from master to 2.0.x November 5, 2020 09:27
@tmbo tmbo changed the title implemented signing secret and updated docs slack connector: implemented signing secret and updated docs Nov 5, 2020
erohmensing
erohmensing reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the screenshots are very helpful!

joejuzl
joejuzl reviewed Nov 5, 2020
View reviewed changes
wochinge
wochinge approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this 🚀
Left a couple of comments but nothing blocking 👍

tmbo and others added 2 commits November 6, 2020 14:32
@tmbo @wochinge
Apply suggestions from code review
603edb5 
Co-authored-by: Tobias Wochinger <t.wochinger@rasa.com>
@tmbo
implemented review comments
2ad5e78
@tmbo tmbo merged commit aec2763 into 2.0.x Nov 8, 2020
@tmbo tmbo deleted the slack-revamp branch November 8, 2020 15:31
@tmbo tmbo restored the slack-revamp branch November 8, 2020 15:36
@b-quachtran b-quachtran mentioned this pull request Nov 16, 2020
Closed
4 tasks
@b-quachtran b-quachtran mentioned this pull request Feb 1, 2021
Closed
@tmbo tmbo deleted the slack-revamp branch May 20, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejuzl joejuzl joejuzl left review comments

@wochinge wochinge wochinge approved these changes

@erohmensing erohmensing erohmensing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1 Rasa Open Source
Development

Successfully merging this pull request may close these issues.
4 participants
@tmbo @joejuzl @wochinge @erohmensing