Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix language supporting setting in JiebaTokenizer #6804

Merged
merged 15 commits into from
Dec 14, 2020
Merged

[bugfix] Fix language supporting setting in JiebaTokenizer #6804

merged 15 commits into from
Dec 14, 2020

Conversation

howl-anderson
Copy link
Contributor

Proposed changes:

  • rename language_list to supported_language_list

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger sara-tagger requested a review from degiz September 28, 2020 06:00
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @degiz will take a look at it as soon as possible ✨

@howl-anderson howl-anderson changed the title [bugfix][WIP] fix language supporting setting in JiebaTokenizer [bugfix] Fix language supporting setting in JiebaTokenizer Oct 9, 2020
degiz
degiz approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@degiz degiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing that 🚀

tmbo
tmbo reviewed Oct 27, 2020
View reviewed changes
@tmbo tmbo changed the base branch from master to 2.0.x October 27, 2020 09:34
@wochinge
Copy link
Contributor

Please change the target to master or 2.1.x once I release Rasa Open Source 2.1 this afternoon.

@howl-anderson Seems like one test is currently failing

@howl-anderson
Copy link
Contributor Author

@wochinge Sorry for the late reply, I will try to fix it today.

@howl-anderson howl-anderson changed the base branch from 2.0.x to master November 23, 2020 02:22
@howl-anderson
Copy link
Contributor Author

@wochinge Please take a look!

@wochinge
Copy link
Contributor

Thanks for the fix 🚀

@wochinge wochinge merged commit aa5e629 into RasaHQ:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo left review comments

@degiz degiz degiz approved these changes

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@howl-anderson @sara-tagger @wochinge @tmbo @degiz