Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for additional training metadata #5743

Merged
merged 8 commits into from
May 18, 2020
Merged

support for additional training metadata #5743

merged 8 commits into from
May 18, 2020

Conversation

kearnsw
Copy link
Contributor

@kearnsw kearnsw commented Apr 28, 2020

Proposed changes:
Described in Issue #5742

Status (please check what you already did):

  • added some tests for the functionality. Requires changing the test data
  • updated the documentation N/A
  • updated the changelog (please check changelog for instructions) Will change when near approval
  • reformat files using black (please check Readme for instructions)

@sara-tagger
Copy link
Collaborator

sara-tagger commented Apr 29, 2020 •
edited by erohmensing
Loading

Thanks for submitting a pull request 🚀 @amn41 will take a look at it as soon as possible ✨

@sara-tagger sara-tagger requested a review from rgstephens April 29, 2020 06:00
tmbo
tmbo approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, makes sense 👍

@tmbo tmbo removed the request for review from rgstephens May 18, 2020 09:18
@tmbo tmbo self-assigned this May 18, 2020
@CLAassistant
Copy link

CLAassistant commented May 18, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tmbo tmbo merged commit a7616d4 into RasaHQ:master May 18, 2020
This was referenced May 19, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees

@tmbo tmbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kearnsw @sara-tagger @CLAassistant @tmbo @rasabot