Add cache_dir config for save HFTransformersNLP pre-trained model data. #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 7, 2020 15:59
Add an optional path to a specific directory to download and cache the pre-trained model weights.
update cache_dir doc
set cache_dir default to null
format
|
Thanks for submitting a pull request 🚀 The assigned reviewer will take a look at it as soon as possible✨ |
wochinge
reviewed
Mar 16, 2020
There was a problem hiding this comment.
Thanks for your contribution @hatunemiku 🎉Can you please also add a changelog entry?
wochinge
reviewed
Mar 16, 2020
Co-Authored-By: Tobias Wochinger <mail@tobias-wochinger.de>
wochinge
reviewed
Mar 18, 2020
wochinge
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
cache_dirfor save HFTransformersNLP pre-trained model dataStatus (please check what you already did):
black(please check Readme for instructions)