[bug] Round Decimal to 9 places to support DynamoDB constraints #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wochinge
reviewed
Jan 20, 2020
rasa/core/utils.py
Outdated
| @@ -477,7 +477,7 @@ def replace_floats_with_decimals(obj: Union[List, Dict]) -> Any: | |||
| obj[j] = replace_floats_with_decimals(obj[j]) | |||
| return obj | |||
| elif isinstance(obj, float): | |||
| return Decimal(obj) | |||
| return round(Decimal(obj), 9) | |||
There was a problem hiding this comment.
7 should even be enough (I just checked how many decimals time.time() returns
There was a problem hiding this comment.
This function will also consume confidence scores, hence the slightly higher value:
{'event': 'user', 'timestamp': Decimal('1579507733.1107571125030517578125'), 'text': 'hi', 'parse_data': {'intent': {'name': 'greet', 'confidence': Decimal('0.918040672051180450807805755175650119781494140625')}
rasa/core/utils.py
Outdated
| @@ -465,7 +465,7 @@ def replace_floats_with_decimals(obj: Union[List, Dict]) -> Any: | |||
| Args: | |||
| obj: A `List` or `Dict` object. | |||
|
|
|||
| Returns: An object with all matching values and `float` type replaced by `Decimal`. | |||
| Returns: An object with all matching values and `float` type replaced by `Decimal` rounded to 9 decimal places. | |||
There was a problem hiding this comment.
Suggested change
| Returns: An object with all matching values and `float` type replaced by `Decimal` rounded to 9 decimal places. | |
| Returns: An object with all matching values and `float` type replaced by `Decimal` rounded to 9 decimal places. |
Suggested change
| Returns: An object with all matching values and `float` type replaced by `Decimal` rounded to 9 decimal places. | |
| Returns: An object with all matching values and `float` types replaced by `Decimal`s rounded to 9 decimal places. |
tests/core/test_utils.py
Outdated
| @@ -98,6 +98,7 @@ def test_float_conversion_to_decimal(): | |||
| d = { | |||
| "int": -1, | |||
| "float": 2.1, | |||
| "float_round": 0.918040672051180450807805755175650119781494140625, | |||
There was a problem hiding this comment.
could you please to the test with an output of time.time(). I think that's the more realistic setting for the tracker store.
rasa/core/utils.py
Outdated
| @@ -477,7 +477,7 @@ def replace_floats_with_decimals(obj: Union[List, Dict]) -> Any: | |||
| obj[j] = replace_floats_with_decimals(obj[j]) | |||
| return obj | |||
| elif isinstance(obj, float): | |||
| return Decimal(obj) | |||
| return round(Decimal(obj), 9) | |||
There was a problem hiding this comment.
can we make the number of decimals a parameter of the function? 9 could be the default value
- Update test to use a time.time() value instead of a confidence score - Add parameter to replace_floats_with_decimals() for setting the rounding precision defaulting to 9 decimal places
wochinge
reviewed
Jan 21, 2020
Co-Authored-By: Tobias Wochinger <mail@tobias-wochinger.de>
wochinge
approved these changes
Jan 22, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
No rounding is currently performed prior to saving to DynamoDB tracker on Decimal values. This can result in saving errors if a value is greater than 38 characters.
Rounded to 9 decimal places as per @akelad's recommendation 🙂
Status (please check what you already did):
black(please check Readme for instructions)