Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luis schema version incompatibility #4759

Closed
wants to merge 15 commits into from
Closed

Luis schema version incompatibility #4759

wants to merge 15 commits into from

Conversation

LucasPenido
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

LucasPenido and others added 9 commits October 17, 2019 17:09
@LucasPenido @LucasLermen
Allowing versions 5 or below of LUIS to be trained
ed9ec0e 
Co-authored-by: LucasLermen <lucas.arthur.lermen@gmail.com>
@LucasLermen @LucasPenido
Add warn message for Luis version incompatibility.
a5b7da7 
Co-authored-by: Lucas Penido <lpenidoa@me.com>
@LucasPenido @LucasLermen
Validating LUIS schema structure
4fd396b 
Co-authored-by: LucasLermen <lucas.arthur.lermen@gmail.com>
@LucasPenido @LucasLermen
Aplying black.
d03920b 
Co-authored-by: LucasLermen <lucas.arthur.lermen@gmail.com>
@LucasPenido @LucasLermen
Changing warnings to logging to warn user.
7522b76 
Co-authored-by: LucasLermen <lucas.arthur.lermen@gmail.com>
@LucasPenido @LucasLermen
Fixing magic number.
70e8d84 
Co-authored-by: LucasLermen <lucas.arthur.lermen@gmail.com>
@LucasLermen @LucasPenido
Removing unused validations.
f603fc4 
Co-authored-by: Lucas Penido <lpenidoa@me.com>
@LucasLermen
Merge branch 'master' of https://github.com/RasaHQ/rasa into Luis_Sch…
560b060 
…ema_Version_Incompatibility
@LucasLermen @LucasPenido
Add fix to changelog.
5dd15d5 
Co-authored-by: Lucas Penido <lpenidoa@me.com>
@CLAassistant
Copy link

CLAassistant commented Nov 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@erohmensing
Copy link
Contributor

Thanks for the PR, we'll give it a review as soon as possible.

@erohmensing erohmensing requested a review from imLew November 14, 2019 09:36
@imLew
Copy link
Contributor

imLew commented Nov 14, 2019

Thanks for the PR @LucasPenido
Since you only changed the warning it seems as though the LUIS reader was actually able to read LUIS schema up to version 4 all along. Could you please share how you verified this?

@LucasPenido
Copy link
Contributor Author

Hi @imLew
I compared all jsons up to version 4 and confirmed that they have the same structure, so I can carantee that until version 4 RASA will train with no errors, after this version a warning will aware the user.

imLew
imLew approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@imLew imLew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wochinge
Copy link
Contributor

@imLew You have to merge, I think @LucasPenido does not have the permissions to do so

wochinge
wochinge reviewed Nov 26, 2019
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@wochinge
Copy link
Contributor

@imLew @LucasPenido How about adding luis v4 file into data/examples/luis and writing a test for it?

tmbo
tmbo requested changes Nov 28, 2019
View reviewed changes
CHANGELOG.rst
@@ -18,6 +18,7 @@ Changed
- Print info message when running Rasa X and a custom model server url was specified in ``endpoints.yml``
- If a ``wait_time_between_pulls`` is configured for the model server in ``endpoints.yml``,
this will be used instead of the default one when running Rasa X
- Training Luis data with ``luis_schema_version`` higher than 4.x.x will show a warning instead of throwing an exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've changed the changelog handling. please do not modify CHANGELOG.rst. instead, please create a new newsfile in changelog/ (more info https://github.com/RasaHQ/rasa/tree/master/changelog)

@imLew imLew mentioned this pull request Dec 3, 2019
Merged
4 tasks
@imLew
Copy link
Contributor

imLew commented Dec 3, 2019

Since all that was left to do was the changelog entry and I could not push to the fork: I created a new PR that does this #4890.

@imLew imLew closed this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imLew imLew imLew approved these changes

@wochinge wochinge wochinge left review comments

@tmbo tmbo tmbo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Luis Schema Version incompatibility
7 participants
@LucasPenido @CLAassistant @erohmensing @imLew @wochinge @tmbo @LucasLermen