Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Base OS to Ubuntu 22.04 #11817

Merged
merged 15 commits into from
Nov 30, 2022
Merged

Upgrade Base OS to Ubuntu 22.04 #11817

merged 15 commits into from
Nov 30, 2022

Conversation

rasa-jmac
Copy link
Contributor

@rasa-jmac rasa-jmac commented Nov 29, 2022 •
edited
Loading

Proposed changes:

  • Upgrade the base OS image in our containers to Ubuntu 22.04.
  • Add Rust compiler which is required by some pip packages on Ubuntu 22.04
  • Update our CI to force image rebuilds whenever the base image is changed.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@rasa-jmac rasa-jmac requested a review from a team as a code owner November 29, 2022 11:20
@rasa-jmac rasa-jmac requested review from rasa-aadlv and removed request for a team and rasa-aadlv November 29, 2022 11:20
@rasa-jmac rasa-jmac requested review from ancalita and m-vdb November 29, 2022 14:08
@rasa-jmac
Copy link
Contributor Author

@ancalita @m-vdb We've had this build successfully, just waiting on the tests running again after we tidied up our work a bit.

Also want to draw your attention to the fact that @miraai found we've had to add Rust to the build images now to successfully build some pip packages on 22.04.

m-vdb
m-vdb reviewed Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @ancalita give a review, as she's far more knowledgeable about the upgrade than me 😉

@rasa-jmac @m-vdb
Update docker/Dockerfile.base
9418402 
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
ancalita
ancalita reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🤩 Could you also please add a changelog entry of type misc? 🙏🏻

@rasa-jmac
Copy link
Contributor Author

Looks great 🤩 Could you also please add a changelog entry of type misc? 🙏🏻

I think I've done this now, but I've not done it before - have I done it right?

ancalita
ancalita approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11817--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@miraai miraai merged commit 1ff5f47 into main Nov 30, 2022
@miraai miraai deleted the feature/ubuntu_22_base branch November 30, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb left review comments

@miraai miraai miraai approved these changes

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rasa-jmac @m-vdb @miraai @ancalita