Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added camembert support #11762

Merged
merged 11 commits into from
Nov 29, 2022
Merged

Added camembert support #11762

merged 11 commits into from
Nov 29, 2022

Conversation

twerkmeister
Copy link
Contributor

@twerkmeister twerkmeister commented Nov 15, 2022

Proposed changes:

  • Support for camembert

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@twerkmeister twerkmeister requested a review from a team as a code owner November 15, 2022 13:55
@twerkmeister twerkmeister requested a review from amn41 November 17, 2022 09:39
Copy link
Contributor

@amn41 amn41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm.

For benchmarking, maybe we can pull some French data from https://github.com/alexa/massive ?

@m-vdb
Copy link
Collaborator

m-vdb commented Nov 28, 2022

@twerkmeister let's link the duckling docs to https://github.com/facebook/duckling

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11762--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@twerkmeister twerkmeister merged commit cde16d6 into 3.3.x Nov 29, 2022
@twerkmeister twerkmeister deleted the core-34-camembert branch November 29, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants