Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded numpy and scikit learn dependencies #11732

Merged
merged 11 commits into from
Nov 8, 2022
Merged

Upgraded numpy and scikit learn dependencies #11732

merged 11 commits into from
Nov 8, 2022

Conversation

twerkmeister
Copy link
Contributor

@twerkmeister twerkmeister commented Nov 2, 2022 •
edited
Loading

Proposed changes:

  • extended numpy range to include 1.23.x for py38 and py39.
  • extended scikit-learn range to include 1.1.x for py38 and py39.
  • extended scipy range to include 1.8.x for py38 and py39
    Note: These versions do not have py37 support.
    These changes will allow us to make the move to tensorflow 2.10

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@twerkmeister twerkmeister changed the base branch from main to 3.3.x November 2, 2022 17:47
@twerkmeister twerkmeister requested a review from a team as a code owner November 3, 2022 10:39
@twerkmeister twerkmeister requested a review from a team as a code owner November 3, 2022 15:08
@twerkmeister twerkmeister requested review from radovanZRasa and removed request for a team November 3, 2022 15:08
m-vdb
m-vdb reviewed Nov 4, 2022
View reviewed changes
m-vdb
m-vdb approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks @twerkmeister

@twerkmeister twerkmeister merged commit 98ed4e0 into 3.3.x Nov 8, 2022
@twerkmeister twerkmeister deleted the core-31-dependencies-upgrade-2 branch November 8, 2022 08:48
twerkmeister added a commit that referenced this pull request Nov 8, 2022
@rasabot @twerkmeister
Upgraded numpy and scikit learn dependencies (#11732) (#11743)
402fbb2 
* upgraded numpy, scikit learn, and scipy, to higher versions

Co-authored-by: Thomas Werkmeister <thomas@werkmeister.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

@radovanZRasa radovanZRasa Awaiting requested review from radovanZRasa radovanZRasa is a code owner automatically assigned from RasaHQ/atom-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twerkmeister @m-vdb