Fix domain slot schema #10782
Merged
Fix domain slot schema #10782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indam23
requested review from
a team and
aeshky
and removed request for
a team
joejuzl
reviewed
Feb 1, 2022
wochinge
reviewed
Feb 4, 2022
rasa/shared/utils/schemas/domain.yml
Outdated
| @@ -47,6 +47,8 @@ mapping: | |||
| regex;([A-Za-z]+): | |||
| type: "map" | |||
| mapping: | |||
| regex;([A-Za-z]+): | |||
There was a problem hiding this comment.
can't we just do allowempty: True? See docs here https://pykwalify.readthedocs.io/en/unstable/validation-rules.html#allowempty
There was a problem hiding this comment.
Indeed! I only discovered where these docs were after the fact so I went off of the rest of the schema, but this makes more sense
indam23
commented
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
slotsoptions, making custom slots with custom keys invalid #10765Status (please check what you already did):
black(please check Readme for instructions)