Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement improvement for customizing logging config #877

Merged
merged 6 commits into from
Nov 7, 2022
Merged

Implement improvement for customizing logging config #877

merged 6 commits into from
Nov 7, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Nov 1, 2022 •
edited
Loading

Proposed changes:

  • Adds a new logging option parameter to the CLI labelled --logging-config-file which accepts a YAML file as value
  • In this YAML file, the rasa developer should provide custom configuration of formatters and handlers (following closely the dictConfig schema in the Python docs)

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

🚀 A preview of the docs have been deployed at the following URL: https://877--rasahq-docsv2-rasa-sdk.netlify.app/docs/action-server

@ancalita ancalita requested review from tmbo and m-vdb November 2, 2022 13:12
@ancalita ancalita marked this pull request as ready for review November 2, 2022 13:12
m-vdb
m-vdb approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ancalita ancalita mentioned this pull request Nov 3, 2022
Closed
5 tasks
@ancalita ancalita merged commit a03bf29 into main Nov 7, 2022
@ancalita ancalita deleted the ATO-454-update-logging-config branch November 7, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

@tmbo tmbo Awaiting requested review from tmbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ancalita @m-vdb