Logging to file for action server #306

dingusagar · 2020-10-15T17:57:47Z

Proposed changes:

Added command line argument option for the action server to save logs to a log file.

Status (please check what you already did):

made PR ready for code review
added some tests for the functionality
updated the documentation
updated the changelog (please check changelog for instructions)
reformat files using black (please check Readme for instructions)

…og-file

…ion_arguments, adding logging file arguments in parset in endpoint.py

CLAassistant · 2020-10-15T17:57:53Z

All committers have signed the CLA.

dingusagar · 2020-10-15T18:07:19Z

Linked issue here #161

roniemartinez · 2020-10-16T01:14:15Z

Awesome! Hope the project owners review this. 💯

sara-tagger · 2020-10-16T06:00:09Z

Thanks for submitting a pull request 🚀 @melindaloubser1 will take a look at it as soon as possible ✨

iwt-kschoenrock · 2020-10-16T14:52:28Z

Wouldn't it be better to use a RotatingFileHandler directly? This would allow you to set backupCount to avoid eventually running out of space because of old logs.
Maybe let the user configure the number of backup files kept around?

dingusagar · 2020-10-17T14:03:12Z

Wouldn't it be better to use a RotatingFileHandler directly? This would allow you to set backupCount to avoid eventually running out of space because of old logs.
Maybe let the user configure the number of backup files kept around?

RotatingFileHandler seems to be a better choice than FileHandler. backupCount argument can be kept to 0 by default so that the default behaviour is a single file growing indefinitely. And user can specify backupCount as a command line argument.

What do you think should be the value of maxBytes argument. Do you feel that needs to be configurable as well? @iwt-kschoenrock / @roniemartinez
Shall I add this enhancement to the PR. Any concerns / thoughts? @melindaloubser1

iwt-kschoenrock · 2020-10-19T09:16:07Z

RotatingFileHandler seems to be a better choice than FileHandler. backupCount argument can be kept to 0 by default so that the default behaviour is a single file growing indefinitely. And user can specify backupCount as a command line argument.

What do you think should be the value of maxBytes argument. Do you feel that needs to be configurable as well? @iwt-kschoenrock / @roniemartinez
Shall I add this enhancement to the PR. Any concerns / thoughts? @melindaloubser1

I don't have any current examples of how big the Rasa Logs would be, maybe someone from Rasa could give an estimate? But I agree that backuptCount and maxBytes should be configurable.

This functionality is important for us, as we're looking for ways to configure ingestion of multi-line logs in Datadog, and the log file would probably be the easiest way to achieve it, apart from the nonplusultra solution, which would be allowing a custom log formatter or log configuration file to be provided.

indam23 · 2020-10-19T09:57:23Z

The action server runs separately from the rasa server, so logging to files for custom actions should be configured on the action server itself (whether rasa-sdk or another action server). The changes look like they're configuring logging of all logs to a file (for the rasa server). Can you clarify the desired behaviour of the change?

… root logger

dingusagar · 2020-10-19T16:02:18Z

The action server runs separately from the rasa server, so logging to files for custom actions should be configured on the action server itself (whether rasa-sdk or another action server). The changes look like they're configuring logging of all logs to a file (for the rasa server). Can you clarify the desired behaviour of the change?

valid point. I have updated the code to configure logging only for action server. I gave "rasa_sdk" as the name for the named logger. so now the configuration is only for loggers within the module rasa_sdk.

Could you review my latest changes? @melindaloubser1
Thanks

indam23

The logging to file works great, but it seems to set the logging level to debug regardless of what is passed as the log level - could you look into that?

dingusagar · 2020-11-04T03:57:29Z

The logging to file works great, but it seems to set the logging level to debug regardless of what is passed as the log level - could you look into that?

Ok I will look into it

…md line

dingusagar · 2020-11-14T06:37:24Z

The logging to file works great, but it seems to set the logging level to debug regardless of what is passed as the log level - could you look into that?

Hi @melindaloubser1
I have pushed the fix for setting the log level of root logger of the project from the command line args. Could you review it.

I noticed that the logger for matplotlib is set to WARN and logger for loglevel for sanic logger is set by environment variables. I have't changed any of those. But let me know if these loglevels also needs to controlled by the arguement passed in the command line args

wochinge · 2020-11-20T13:16:23Z

fixing the code_quality step here. Sorry for the inconvenience!

indam23

Can you run make formatter and apply the changes? The linting step is failing.

rasa_sdk/utils.py

dingusagar · 2021-01-06T17:45:48Z

Can you run make formatter and apply the changes? The linting step is failing.

sure @melindaloubser1
have made the changes for the errors given by make lint

indam23 · 2021-01-06T17:48:20Z

Sorry one more thing, can you add a changelog entry please? You'll find instructions for that in the changelog/README.md

dingusagar · 2021-01-06T18:05:47Z

Sorry one more thing, can you add a changelog entry please? You'll find instructions for that in the changelog/README.md

added a changelog entry.

dingusagar added 4 commits October 15, 2020 23:24

added method in utils for configuring loggging in file

a9adc18

added method in utils for adding new parser argument for mentioning l…

1f31eb5

…og-file

file logging configuration method called inside __main__.py

cc61208

renaming add_logging_option_arguments method to add_logging_level_opt…

8a01aed

…ion_arguments, adding logging file arguments in parset in endpoint.py

dingusagar mentioned this pull request Oct 15, 2020

Add --log-file option when using the action server #161

Closed

1 task

dingusagar changed the title ~~Logging file for action~~ Logging to file for action server Oct 15, 2020

indam23 self-requested a review October 19, 2020 09:54

dingusagar added 3 commits October 19, 2020 20:45

adding module name to log formatter

eda9d8f

added application root logger name

5e0a176

logging to file configuration changed from root logger to application…

35381d4

… root logger

formatting code in utils.py

3951388

indam23 suggested changes Nov 3, 2020

View reviewed changes

logging level of root logger set to args.loglevel to configure from c…

5e85e00

…md line

dingusagar requested a review from indam23 January 3, 2021 05:12

Merge branch 'master' into logging-file-for-action

949e705

indam23 suggested changes Jan 5, 2021

View reviewed changes

dingusagar added 2 commits January 6, 2021 21:04

fixing code formatting

d2b5500

Merge branch 'master' into logging-file-for-action

92f7d04

dingusagar added 2 commits January 6, 2021 23:09

fixing code lintings for rasa_sdk/__main__.py

80f7954

rasa_sdk/utils.py

fixing code linting errors for rasa_sdk/interfaces.py

94a1506

dingusagar requested a review from indam23 January 6, 2021 17:46

indam23 approved these changes Jan 6, 2021

View reviewed changes

updated changelog

b203c26

dingusagar requested a review from indam23 January 7, 2021 04:16

indam23 merged commit 2e922f5 into RasaHQ:master Jan 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logging to file for action server #306

Logging to file for action server #306

dingusagar commented Oct 15, 2020 •

edited

Loading

CLAassistant commented Oct 15, 2020 •

edited

Loading

dingusagar commented Oct 15, 2020

roniemartinez commented Oct 16, 2020

sara-tagger commented Oct 16, 2020

iwt-kschoenrock commented Oct 16, 2020

dingusagar commented Oct 17, 2020 •

edited

Loading

iwt-kschoenrock commented Oct 19, 2020

indam23 commented Oct 19, 2020 •

edited

Loading

dingusagar commented Oct 19, 2020 •

edited

Loading

indam23 left a comment

dingusagar commented Nov 4, 2020

dingusagar commented Nov 14, 2020 •

edited

Loading

wochinge commented Nov 20, 2020

indam23 left a comment

dingusagar commented Jan 6, 2021

indam23 commented Jan 6, 2021

dingusagar commented Jan 6, 2021

Logging to file for action server #306

Logging to file for action server #306

Conversation

dingusagar commented Oct 15, 2020 • edited Loading

CLAassistant commented Oct 15, 2020 • edited Loading

dingusagar commented Oct 15, 2020

roniemartinez commented Oct 16, 2020

sara-tagger commented Oct 16, 2020

iwt-kschoenrock commented Oct 16, 2020

dingusagar commented Oct 17, 2020 • edited Loading

iwt-kschoenrock commented Oct 19, 2020

indam23 commented Oct 19, 2020 • edited Loading

dingusagar commented Oct 19, 2020 • edited Loading

indam23 left a comment

Choose a reason for hiding this comment

dingusagar commented Nov 4, 2020

dingusagar commented Nov 14, 2020 • edited Loading

wochinge commented Nov 20, 2020

indam23 left a comment

Choose a reason for hiding this comment

dingusagar commented Jan 6, 2021

indam23 commented Jan 6, 2021

dingusagar commented Jan 6, 2021

dingusagar commented Oct 15, 2020 •

edited

Loading

CLAassistant commented Oct 15, 2020 •

edited

Loading

dingusagar commented Oct 17, 2020 •

edited

Loading

indam23 commented Oct 19, 2020 •

edited

Loading

dingusagar commented Oct 19, 2020 •

edited

Loading

dingusagar commented Nov 14, 2020 •

edited

Loading