FormSlotsValidatorAction added

[alwx]

Proposed changes:

• fix Custom action class for validating slots with one custom action rasa#6819

Status (please check what you already did):

• made PR ready for code review
• added some tests for the functionality
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[alwx]

Will update https://rasa.com/docs/rasa/forms#validating-form-input once we merge this one :)

[wochinge]

I'll try to squeeze in the review between retro and tech onboarding .Do you already have a matching docs PR on Rasa Open Source side?

[wochinge]

Nice testing 🥇 Left a couple of comments 🙈

[wochinge]

let's also add a usage example :)

[wochinge]

I meant actually here in the changelog. I think users are more likely to look into the changelog then the codebase.

[wochinge]

looks great

[wochinge]

I meant actually here in the changelog. I think users are more likely to look into the changelog then the codebase.

[alwx]

I made it work the way it worked before (in the current implementation events get updated in slots dictionary) but I still have no idea if it's the right behavior or not because there is nothing about it in the description.
@wochinge could you please check and verify if the logic is correct?

[wochinge]

I made it work the way it worked before (in the current implementation events get updated in slots dictionary) but I still have no idea if it's the right behavior or not because there is nothing about it in the description.

Looks great 🥇 Just a few comments, then we're ready to go. Where would you expect a description?

[wochinge]

@alwx I thought about whether the validation_function should return a List[EventType] (e.g. SlotSet for the validated slots) instead of the dictionary which we are currently returning. I think it makes sense to do it as you did and keep the old implementation which returns the plain Dict as users were happy with that and then there is one less thing for them to re-learn / change.

[alwx]

@wochinge done

[wochinge]

💯