Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsed css for page_detail containers display doesn't work #241

Open
juergmessmer opened this issue Jun 4, 2018 · 10 comments
Open

Parsed css for page_detail containers display doesn't work #241

juergmessmer opened this issue Jun 4, 2018 · 10 comments
Assignees
Milestone

Comments

@juergmessmer
Copy link
Member

No containers are displayed, no errors
use_parsed_css_in_config: true

@juergmessmer juergmessmer changed the title Parsed css for page_detail container display doesn't work Parsed css for page_detail containers display doesn't work Jun 4, 2018
@juergmessmer juergmessmer added this to the Release 2 milestone Jun 4, 2018
@juergmessmer
Copy link
Member Author

this setting also affects correct loading of page js: clicking on edit template and page type dialog doesn't work (Safari). Also changes in templates don't take effect when clearing the caches (Safari and Firefox).

@sabberworm
Copy link
Member

sabberworm commented Jun 12, 2018

Does this affect 1.7 or 1.5 as well or only master?

@juergmessmer
Copy link
Member Author

I’ll have to test it

@juergmessmer
Copy link
Member Author

I can't test it anymore since release-1.5 is not compatible with my php 7 environment.

@sabberworm
Copy link
Member

Tested with cms-full. Both branches (master and release-1.7) work fine.

screen shot 2018-06-18 at 21 18 49

@sabberworm
Copy link
Member

But there are many CSS3 (and beyond) features that PHP-CSS-Parser does not support. Maybe your site uses one of those?

@juergmessmer
Copy link
Member Author

I don't understand all the issues, for example MyIntervals/PHP-CSS-Parser#125
Regarding background-position, I only use background-position: left center; not the suggested background-position: top left, right bottom;

@sabberworm
Copy link
Member

I don't understand all the issues, for example MyIntervals/PHP-CSS-Parser#125
Regarding background-position, I only use background-position: left center; not the suggested background-position: top left, right bottom;

Well, then it does not apply to you, does it?

@sabberworm
Copy link
Member

Also I think you mean MyIntervals/PHP-CSS-Parser#123, not 125

@juergmessmer
Copy link
Member Author

No, I meant the one related to "... declare color", I didn't understand that issue. The one related to background-position I checked and couldn't find any rules using the statements suggested in the related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants