Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies for string overwriting don't seem to work #206

Open
juergmessmer opened this issue Apr 8, 2015 · 2 comments
Open

Dependencies for string overwriting don't seem to work #206

juergmessmer opened this issue Apr 8, 2015 · 2 comments

Comments

@juergmessmer
Copy link
Member

If I make a placeholder string in a widget, that can be overwritten by another plugin or for a special site, I expect that a string (key) added to a plugin2 - which depends on plugin1 - is displayed instead of the original one. But that doesn't seem to work - even if I use the same path / dir structure in both plugins.

Plugin1
placeholder.string-key: ""

Plugin2
info.yml
dependencies:
plugins/plugin1: "*"
placeholder.string-key: "My overwrite string"

@sabberworm
Copy link
Member

My tests show the following:

plugins/«p»/modules/«t»/«m»/lang/«l».ini can be overridden by site/modules/«t»/«m»/lang/«l».ini but not by site/lang/«l».ini. I don’t know if that is supposed to be correct…

@juergmessmer
Copy link
Member Author

I havn't had any problems with this anymore. I guess we close it for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants